Add open-graph tags support - #31
Conversation
|
@jchapuis Can you please rebase to solve conflicts? Thanks! |
f18986d to
b30f8e2
Compare
|
@mkurz sure! done |
b30f8e2 to
c0bb47d
Compare
c0bb47d to
fc5fb68
Compare
|
@jchapuis You need to format the codebase |
yes i saw it was build.sbt i believe, pushed a commit |
mdedetrich
left a comment
mdedetrich
left a comment
There was a problem hiding this comment.
I think one of the URI's need to be updated
mdedetrich
left a comment
mdedetrich
left a comment
There was a problem hiding this comment.
lgtm. @mkurz Want to take a look?
| <meta http-equiv="x-ua-compatible" content="ie=edge"> | ||
| <meta name="description" content="$page.properties.("project.description")$"> | ||
| $ if (page.properties.("project.name")) $ | ||
| <meta property="og:title" content="$page.properties.("project.name")$"> |
There was a problem hiding this comment.
Not sure if we should use project name as og:title.
Shouldn't we use something like here instead?
sbt-paradox-material-theme/theme/src/main/assets/page.st
Lines 48 to 54 in 4b214d8
There was a problem hiding this comment.
I think those were metadata of open graph
There was a problem hiding this comment.
@Roiocam I understand that, however my point is if it makes sense to use the "project name" as og:title. Maybe it would be better to use the same value like we use for the html <title> tag.
There was a problem hiding this comment.
good point, changed, but i kept the condition logic simple, where you have to define the page title property for it to be exposed in opengraph. Or would we want to have the same logic? trying to avoid unnecessary duplication
| <meta http-equiv="x-ua-compatible" content="ie=edge"> | ||
| <meta name="description" content="$page.properties.("project.description")$"> | ||
| $ if (page.properties.("project.name")) $ | ||
| <meta property="og:title" content="$page.properties.("project.name")$"> |
There was a problem hiding this comment.
I think those were metadata of open graph
|
/cc @mdedetrich maybe you can also take a look here if you have time |
4 participants
No description provided.